seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

Fix background in settings window #722

Open
EricKotato wants to merge 1 commits from EricKotato/patch-2 into master
pull from: EricKotato/patch-2
merge into: seeseemelk:master
Conversation 5 Commits 1 Files Changed 1 +1
EricKotato commented 2022-05-28 17:38:36 +02:00 (Migrated from github.com)
Copy Link

Fixes #428, fixes #612, fixes #689

Settings window text is unreadable in dark themes because background is white on any theme. This PR fixes the problem. Works with both dark and light themes.

After fix:

Fixes #428, fixes #612, fixes #689 Settings window text is unreadable in dark themes because background is white on any theme. This PR fixes the problem. Works with both dark and light themes. After fix: ![](https://user-images.githubusercontent.com/2903496/170832302-323d9cc6-0e3f-40a6-9716-c6fc9d207df3.png) ![](https://user-images.githubusercontent.com/2903496/170832335-35513f47-fd55-43ab-aad4-be3f40b0cff0.png)
EricKotato commented 2022-05-28 17:49:50 +02:00 (Migrated from github.com)
Copy Link

Whoops, looks like renaming the branch closes the PR. That wasn't intended.

Whoops, looks like renaming the branch closes the PR. That wasn't intended.
jlederman commented 2022-07-26 20:02:04 +02:00 (Migrated from github.com)
Copy Link

I'm using the Breeze dark theme with KDE and can confirm this change works as intended.

I'm using the Breeze dark theme with KDE and can confirm this change works as intended.
MrAureliusR commented 2022-10-04 02:26:31 +02:00 (Migrated from github.com)
Copy Link

This fixes multiple reported issues... it should be merged ASAP! Seems there's not a lot of activity in this repo anymore.

This fixes multiple reported issues... it should be merged ASAP! Seems there's not a lot of activity in this repo anymore.
wd5gnr commented 2023-01-11 14:44:42 +01:00 (Migrated from github.com)
Copy Link

Quick workaround: launch like this:

QT_QUICK_CONTROLS_STYLE=Material cool-retro-term

Ugly, but you can read it. This bug is in a few different places.

Quick workaround: launch like this: QT_QUICK_CONTROLS_STYLE=Material cool-retro-term Ugly, but you can read it. This bug is in a few different places.
tony-pelton commented 2023-07-12 04:49:00 +02:00 (Migrated from github.com)
Copy Link

fwiw, can confirm, this patch solves the problem described on my KDE desktop.

fwiw, can confirm, this patch solves the problem described on my KDE desktop.
seeseemelk force-pushed EricKotato/patch-2 from 3c526d94ef to 69792c063d 2024-10-11 10:58:42 +02:00 Compare
seeseemelk added the
priority
low
 label 2024-10-11 11:01:37 +02:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin EricKotato/patch-2:EricKotato/patch-2
git checkout EricKotato/patch-2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
priority
low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#722
No description provided.
Delete Branch "EricKotato/patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?