seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

Scanline fixes #653

Open
ryanfelder wants to merge 3 commits from ryanfelder/scanline_fixes into master
pull from: ryanfelder/scanline_fixes
merge into: seeseemelk:master
Conversation 0 Commits 3 Files Changed 5 +117 -7
ryanfelder commented 2021-04-28 02:51:45 +02:00 (Migrated from github.com)
Copy Link

This resolves two issues with scanline rendering :

  • Burn-in does not respect/include rasterization (scanlines or pixels)
  • Scanlines end abruptly

Example of burn-in issue:

Screenshot from 2021-04-27 12 11 06

Example of both issues fixed:
Screenshot from 2021-04-27 17 47 49

Example of "scanlines end abruptly":

Screenshot from 2021-04-27 16 49 37

Similar screenshot with horizontal-only scanline blurring enabled (5%):

Screenshot from 2021-04-27 16 49 53

I've never used QML before, and I know nothing about shaders, so apologies for the brute-force solutions.

This resolves two issues with scanline rendering : * Burn-in does not respect/include rasterization (scanlines or pixels) * Scanlines end abruptly Example of burn-in issue: ![Screenshot from 2021-04-27 12 11 06](https://user-images.githubusercontent.com/7475484/116329541-2f43c880-a791-11eb-8331-82d296dfdaf2.png) Example of both issues fixed: ![Screenshot from 2021-04-27 17 47 49](https://user-images.githubusercontent.com/7475484/116329759-a2e5d580-a791-11eb-85a0-422515c3ca13.png) Example of "scanlines end abruptly": ![Screenshot from 2021-04-27 16 49 37](https://user-images.githubusercontent.com/7475484/116329656-729e3700-a791-11eb-93b7-8fd47c7837ec.png) Similar screenshot with horizontal-only scanline blurring enabled (5%): ![Screenshot from 2021-04-27 16 49 53](https://user-images.githubusercontent.com/7475484/116329709-89dd2480-a791-11eb-96bd-1a8cabf0c5a0.png) I've never used QML before, and I know nothing about shaders, so apologies for the brute-force solutions.
seeseemelk added the
priority
high
 label 2024-10-11 11:06:05 +02:00
This pull request has changes conflicting with the target branch.
  • app/qml/ApplicationSettings.qml
  • app/qml/SettingsEffectsTab.qml
  • app/qml/ShaderTerminal.qml
  • app/qml/SlowBurnIn.qml
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ryanfelder/scanline_fixes:ryanfelder/scanline_fixes
git checkout ryanfelder/scanline_fixes
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
priority
high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#653
No description provided.
Delete Branch "ryanfelder/scanline_fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?