seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests Actions Packages Projects Releases 8 Wiki Activity

Fix rendering on non HiDPI screens #646

Closed
sacredbanana wants to merge 1 commits from rendering-fix-for-non-HiDPI-screens into master
pull from: rendering-fix-for-non-HiDPI-screens
merge into: seeseemelk:master
Conversation 2 Commits 1 Files Changed 5
+1688 -2071
sacredbanana commented 2021-03-28 03:10:01 +02:00 (Migrated from github.com)
Copy Link
Copy Source

If you have more than one monitor and you drag cool-retro-term from a HiDPI (Retina) screen to a lower resolution screen, the rendering would be at an unreadable low resolution.

Resolves #541

If you have more than one monitor and you drag cool-retro-term from a HiDPI (Retina) screen to a lower resolution screen, the rendering would be at an unreadable low resolution. Resolves #541
❤️ 3
Swordfish90 commented 2021-07-01 23:02:54 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Hi @sacredbanana . Thank you for this PR and I'm very sorry for the very late review. I just tested it under Linux with Qt 5.12 and I'm having a few issues while playing with QT_SCALE_FACTOR so I'll be adding a few comments.

Hi @sacredbanana . Thank you for this PR and I'm very sorry for the very late review. I just tested it under Linux with Qt 5.12 and I'm having a few issues while playing with QT_SCALE_FACTOR so I'll be adding a few comments.
Swordfish90 (Migrated from github.com) requested changes 2021-07-01 23:08:49 +02:00
app/qml/Fonts.qml
@@ -29,1 +30,3 @@
property int pixelSize: lowResolutionFont ? _font.pixelSize : _font.pixelSize * scaling
property int pixelSize: lowResolutionFont
? _font.pixelSize * 2.0 / appSettings.pixelRatio
: _font.pixelSize * scaling
Swordfish90 (Migrated from github.com) commented 2021-07-01 23:05:28 +02:00
Copy Link
Copy Source

With the lowResolutionFont size should be static (like when scanlines are applied), this created some issues in my tests. Does it behave differently in your tests if you revert this line?

With the lowResolutionFont size should be static (like when scanlines are applied), this created some issues in my tests. Does it behave differently in your tests if you revert this line?
app/qml/main.qml
@@ -35,0 +34,4 @@
appSettings.x = x
appSettings.pixelRatio = Window.devicePixelRatio
}
onYChanged: {
Swordfish90 (Migrated from github.com) commented 2021-07-01 23:08:28 +02:00
Copy Link
Copy Source

In my tests with Qt 5.12 this always returns undefined. Did you mean something like "terminalWindow.screen.devicePixelRatio"?

In my tests with Qt 5.12 this always returns undefined. Did you mean something like "terminalWindow.screen.devicePixelRatio"?

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Swordfish90
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk (Sebastiaan de Schaetzen)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#646
Delete Branch "rendering-fix-for-non-HiDPI-screens"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?