seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

Multiple terminal support on MacOS #507

Closed
adammathes wants to merge 13 commits from adammathes/master into master
pull from: adammathes/master
merge into: seeseemelk:master
Conversation 7 Commits 13 Files Changed 5 +68 -5
adammathes commented 2019-02-10 05:54:24 +01:00 (Migrated from github.com)
Copy Link

This is an attempt to enable multiple terminal windows.

Only tested on MacOS but it works for me. Looking for feedback --

  1. Does this work for anyone else and would it be useful?
  2. Does this is approach make sense? I'm new to QT/QML
  3. Is it worth testing/validating on Linux or should it just be limited to MacOS?
This is an attempt to enable multiple terminal windows. Only tested on MacOS but it works for me. Looking for feedback -- 1. Does this work for anyone else and would it be useful? 2. Does this is approach make sense? I'm new to QT/QML 3. Is it worth testing/validating on Linux or should it just be limited to MacOS?
👍 1
adammathes commented 2019-02-10 06:44:25 +01:00 (Migrated from github.com)
Copy Link

Oops, this still doesn't quit cleanly. I'll work on it some more before resubmitting.

Oops, this still doesn't quit cleanly. I'll work on it some more before resubmitting.
adammathes commented 2019-02-10 17:40:51 +01:00 (Migrated from github.com)
Copy Link

Turns out the not quitting cleanly behavior is reproducible on the release 1.1.1 build as well, so I'll file an issue separately on that, it doesn't look related to these changes.

Turns out the not quitting cleanly behavior is reproducible on the release 1.1.1 build as well, so I'll file an issue separately on that, it doesn't look related to these changes.
Swordfish90 commented 2019-02-11 09:22:43 +01:00 (Migrated from github.com)
Copy Link

I'd answer yes to all three questions. Linux side, the benefits might be a bit less, but I believe it's still worth it.

The implementation is good, but I think we need some refactoring to take into account multiple windows.

Some items are "singletons" by design, and should be moved to the root element. I think we should only have one ApplicationSettings (which should be the only interface to the db), and only one SettingsWindow and AboutDialog.

If you need some help I can also merge this into a feature branch.

I'd answer yes to all three questions. Linux side, the benefits might be a bit less, but I believe it's still worth it. The implementation is good, but I think we need some refactoring to take into account multiple windows. Some items are "singletons" by design, and should be moved to the root element. I think we should only have one ApplicationSettings (which should be the only interface to the db), and only one SettingsWindow and AboutDialog. If you need some help I can also merge this into a feature branch.
adammathes commented 2019-02-12 02:54:22 +01:00 (Migrated from github.com)
Copy Link

Ok, I'll take a pass at trying to do the refactoring and see how far I can get.

Would definitely welcome help on it.

Ok, I'll take a pass at trying to do the refactoring and see how far I can get. Would definitely welcome help on it.
atmadeep commented 2019-10-16 16:42:00 +02:00 (Migrated from github.com)
Copy Link

I'd answer yes to all three questions. Linux side, the benefits might be a bit less, but I believe it's still worth it.

The implementation is good, but I think we need some refactoring to take into account multiple windows.

Some items are "singletons" by design, and should be moved to the root element. I think we should only have one ApplicationSettings (which should be the only interface to the db), and only one SettingsWindow and AboutDialog.

If you need some help I can also merge this into a feature branch.

Yes please. I write and run code for robots and computer vision applications. So I use terminator for multiple terminals, but I would really like to have this as my daily driver terminal.

> I'd answer yes to all three questions. Linux side, the benefits might be a bit less, but I believe it's still worth it. > > The implementation is good, but I think we need some refactoring to take into account multiple windows. > > Some items are "singletons" by design, and should be moved to the root element. I think we should only have one ApplicationSettings (which should be the only interface to the db), and only one SettingsWindow and AboutDialog. > > If you need some help I can also merge this into a feature branch. Yes please. I write and run code for robots and computer vision applications. So I use terminator for multiple terminals, but I would really like to have this as my daily driver terminal.
adammathes commented 2019-10-17 04:08:34 +02:00 (Migrated from github.com)
Copy Link

Unfortunately I don't have the time to refactor and care for this properly - but I'd encourage someone to merge it into a feature branch and fix it (or just fork this and fix it)

Unfortunately I don't have the time to refactor and care for this properly - but I'd encourage someone to merge it into a feature branch and fix it (or just fork this and fix it)
seeseemelk commented 2024-10-11 11:12:12 +02:00
Copy Link

Will close this as it's not finished

Will close this as it's not finished
seeseemelk closed this pull request 2024-10-11 11:12:12 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#507
No description provided.
Delete Branch "adammathes/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?