seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests Actions Packages Projects Releases 8 Wiki Activity

Fix: issue #387 transparent menu bar (and two other theme issues) #388

Closed
syddel wants to merge 1 commits from master into master
pull from: master
merge into: seeseemelk:master
Conversation 1 Commits 1 Files Changed 4
+3076 -4142
syddel commented 2017-11-01 11:57:54 +01:00 (Migrated from github.com)
Copy Link
Copy Source

Using Kubuntu 17.10 (KDE Plasma 5.10.5) with Breeze Dark theme selected, the main MenuBar is transparent, the Settings window background is white (instead of dark), and the Save New Profile dialog is not themed correctly. Modified the following to fix these issues:

app/qml/main.qml (line 65)
app/qml/SettingsWindow.sql (added lines 35 and 36)
app/sql/InsertNameDialog.sql (added lines 34 and 35)

(first time I've dabbled with QML, so not sure if there's a better/proper way of doing this)

Using Kubuntu 17.10 (KDE Plasma 5.10.5) with Breeze Dark theme selected, the main MenuBar is transparent, the Settings window background is white (instead of dark), and the Save New Profile dialog is not themed correctly. Modified the following to fix these issues: app/qml/main.qml (line 65) app/qml/SettingsWindow.sql (added lines 35 and 36) app/sql/InsertNameDialog.sql (added lines 34 and 35) (first time I've dabbled with QML, so not sure if there's a better/proper way of doing this)
Swordfish90 commented 2018-02-25 12:19:29 +01:00 (Migrated from github.com)
Copy Link
Copy Source

Sorry for the very late response... I see a couple of issue with this pull request...

  1. There is a moc_ file included
  2. Setting color: "#FF000000" in main.qml is going to break transparency (because window "background" will become black opaque)
Sorry for the very late response... I see a couple of issue with this pull request... 1) There is a moc_ file included 2) Setting color: "#FF000000" in main.qml is going to break transparency (because window "background" will become black opaque)

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk (Sebastiaan de Schaetzen)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#388
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?