seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests Actions Packages Projects Releases 8 Wiki Activity

Add a Kindle theme to the default profile list. #242

Closed
JoshTheDerf wants to merge 1 commits from kindle-theme into master
pull from: kindle-theme
merge into: seeseemelk:master
Conversation 11 Commits 1 Files Changed 1
+5
JoshTheDerf commented 2015-04-24 05:29:55 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Add a theme based on the Kindle (Keyboard 3rd gen.) as per request of @niedzielski in #241.

This theme does have some issues with washed-out, value-inverted color inherent to light themes, but hopefully that will be resolved in a core commit later on.

Add a theme based on the Kindle (Keyboard 3rd gen.) as per request of @niedzielski in #241. This theme does have some issues with washed-out, value-inverted color inherent to light themes, but hopefully that will be resolved in a core commit later on.
niedzielski commented 2015-04-24 06:07:42 +02:00 (Migrated from github.com)
Copy Link
Copy Source

👍 Works on my machine!

:+1: Works on my machine!
KAMiKAZOW commented 2015-04-24 11:24:43 +02:00 (Migrated from github.com)
Copy Link
Copy Source

What's 1980's retro about a Kindle?

What's 1980's retro about a Kindle?
JoshTheDerf commented 2015-04-24 15:13:06 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@KAMiKAZOW Nothing really. :/

@KAMiKAZOW Nothing really. :/
KAMiKAZOW commented 2015-04-24 20:35:13 +02:00 (Migrated from github.com)
Copy Link
Copy Source

IMO such themes should be 3rd party downloads. Filippo implemented Import and Export features months ago (see #112).

IMO such themes should be 3rd party downloads. Filippo implemented Import and Export features months ago (see #112).
JoshTheDerf commented 2015-04-25 01:14:43 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@KAMiKAZOW That would probably be the best idea, but I'll wait for a few more opinions. :)

Perhaps we could have a wiki page with user-generated themes?

@KAMiKAZOW That would probably be the best idea, but I'll wait for a few more opinions. :) Perhaps we could have a wiki page with user-generated themes?
niedzielski commented 2015-04-25 01:40:27 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@Tribex I'm obviously for it :) I think it's a really great demo of the versatility possible in CRT and something some users would love out of the box.

@KAMiKAZOW Since the first Kindle came out in 2007, some kids would call that retro. Furthermore, I think the appearance is also not unlike an LCD found in an old Casio digital watch or a Tiger Electronics handheld. Have you tried it yet? It's super retro!

@Tribex I'm obviously for it :) I think it's a really great demo of the versatility possible in CRT and something some users would love out of the box. @KAMiKAZOW Since the first Kindle came out in 2007, some kids would call that retro. Furthermore, I think the appearance is also not unlike an LCD found in an old Casio digital watch or a Tiger Electronics handheld. Have you tried it yet? It's super retro!
Swordfish90 commented 2015-05-05 11:25:48 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@Tribex ... Sorry for the late answer, but personally I don't think this layout fits among the default ones. I believe the default profiles should all have a "retro feeling" in order to make the experience consistent. Anyway you are very welcomed to share your profiles in the json format!

@Tribex ... Sorry for the late answer, but personally I don't think this layout fits among the default ones. I believe the default profiles should all have a "retro feeling" in order to make the experience consistent. Anyway you are very welcomed to share your profiles in the json format!
JoshTheDerf commented 2015-05-05 11:33:58 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@Swordfish90 I'm perfectly fine with that. In fact, it would probably be preferable to share user themes somewhere else.

With that in mind, could a wiki page be created for sharing user themes?

@Swordfish90 I'm perfectly fine with that. In fact, it would probably be preferable to share user themes somewhere else. With that in mind, could a wiki page be created for sharing user themes?
Swordfish90 commented 2015-05-05 11:40:48 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@Tribex . Definitely agreed. The wiki would be the perfect place to share them.

@Tribex . Definitely agreed. The wiki would be the perfect place to share them.
JoshTheDerf commented 2015-05-05 11:43:08 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@Swordfish90 Excellent, will do.

@Swordfish90 Excellent, will do.
Swordfish90 commented 2015-05-05 12:08:01 +02:00 (Migrated from github.com)
Copy Link
Copy Source

@Tribex . It looks great. Thank you!

@Tribex . It looks great. Thank you!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk (Sebastiaan de Schaetzen)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#242
Delete Branch "kindle-theme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?