seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests Actions Packages Projects Releases 8 Wiki Activity

Updated the README.md with some more up to date screenshots showing off ... #129

Closed
Honeybunch wants to merge 2 commits from master into master
pull from: master
merge into: seeseemelk:master
Conversation 4 Commits 2 Files Changed 1
+27456 -5313
Honeybunch commented 2014-09-24 06:17:17 +02:00 (Migrated from github.com)
Copy Link
Copy Source

...some of the settings and at different resolutions too.

...some of the settings and at different resolutions too.
Swordfish90 commented 2014-09-24 11:36:08 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Thank you very much!... Could you please make some adjustments? The issue was opened here: https://github.com/Swordfish90/cool-retro-term/issues/113 .

  • There is a link with some suggestions regarding image style, sizes and everything; plese make sure they comply with those.
  • Could you please run some programs so that the screen looks a little bit more engaging? (man gcc, cowsay, cmatrix, ninvaders, nethack, cowsay or whatever you prefer).
  • Can you hide the menubar, which does not look good under elementary os Luna?

Sorry for the tediousness, but the images are really important to catch the attention of the user. If you have any question I'm here to help.

Thank you again for your contribution.

Thank you very much!... Could you please make some adjustments? The issue was opened here: https://github.com/Swordfish90/cool-retro-term/issues/113 . - There is a link with some suggestions regarding image style, sizes and everything; plese make sure they comply with those. - Could you please run some programs so that the screen looks a little bit more engaging? (man gcc, cowsay, cmatrix, ninvaders, nethack, cowsay or whatever you prefer). - Can you hide the menubar, which does not look good under elementary os Luna? Sorry for the tediousness, but the images are really important to catch the attention of the user. If you have any question I'm here to help. Thank you again for your contribution.
Honeybunch commented 2014-09-24 19:10:09 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Sorry for the late response, adjustments are no problem!
I'll give it another shot in just a bit and throw you another pull request.

Sorry for the late response, adjustments are no problem! I'll give it another shot in just a bit and throw you another pull request.
Honeybunch commented 2014-09-24 19:49:23 +02:00 (Migrated from github.com)
Copy Link
Copy Source

Alrighty, I hid the ElementaryOS title bar, and made every image the same size. Showed off some Vim editing and compiled the project with it. Let me know if there are any other changes you'd like or if you'd like more screens :)

Alrighty, I hid the ElementaryOS title bar, and made every image the same size. Showed off some Vim editing and compiled the project with it. Let me know if there are any other changes you'd like or if you'd like more screens :)
Swordfish90 commented 2014-09-28 10:52:54 +02:00 (Migrated from github.com)
Copy Link
Copy Source

I'm extremely sorry. I've only noticed right now that the message I believed I sent is not here. I thought I answered three days ago!... Anyway there has been a misunderstanding, I was talking about the menubar and not the title bar (right click on the terminal and untick "Show Menubar"). This is the one that is not themed correctly in Qt5 under elementary.

The new pictures are better but there are still a couple of issues, the text looks very small when the image is scaled, and please use also some funny programs like the ones suggested in the first comment.

I'm extremely sorry. I've only noticed right now that the message I believed I sent is not here. I thought I answered three days ago!... Anyway there has been a misunderstanding, I was talking about the menubar and not the title bar (right click on the terminal and untick "Show Menubar"). This is the one that is not themed correctly in Qt5 under elementary. The new pictures are better but there are still a couple of issues, the text looks very small when the image is scaled, and please use also some funny programs like the ones suggested in the first comment.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk (Sebastiaan de Schaetzen)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#129
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?