seeseemelk/ollama4j
1
0
Fork 0
forked from Mirror/ollama4j
Code Issues Pull Requests Actions Packages Releases 1 Activity

Add configurable timeouts for image URL loading

Browse Source 
Introduces connect and read timeout settings for loading images from URLs in OllamaAPI and OllamaChatRequestBuilder. Refactors Utils to use HttpClient for image retrieval with timeout support and improves error handling and logging. Updates unit tests to verify builder robustness against malformed URLs.
This commit is contained in:
Amith Koujalgi
2025-09-16 10:31:32 +05:30
parent 656802b343
commit 70519e3309
4 changed files with 63 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/test/java/io/github/ollama4j/unittests/TestOllamaChatRequestBuilder.java
View File

@@ -33,17 +33,22 @@ class TestOllamaChatRequestBuilder {
@Test
void testImageUrlFailuresAreIgnoredAndDoNotBreakBuild() {
// Provide clearly invalid URL, builder logs a warning and continues
OllamaChatRequest req = OllamaChatRequestBuilder.getInstance("m")
.withMessage(OllamaChatMessageRole.USER, "hi", Collections.emptyList(),
"ht!tp://invalid url \n not a uri")
// Provide a syntactically invalid URL, but catch the expected exception to verify builder robustness
OllamaChatRequestBuilder builder = OllamaChatRequestBuilder.getInstance("m");
try {
builder.withMessage(OllamaChatMessageRole.USER, "hi", Collections.emptyList(),
"ht!tp://invalid url \n not a uri");
fail("Expected IllegalArgumentException due to malformed URL");
} catch (IllegalArgumentException e) {
// Expected: malformed URL should throw IllegalArgumentException
}
// The builder should still be usable after the exception
OllamaChatRequest req = builder.withMessage(OllamaChatMessageRole.USER, "hello", Collections.emptyList())
.build();
assertNotNull(req.getMessages());
assertEquals(1, req.getMessages().size());
OllamaChatMessage msg = req.getMessages().get(0);
// images list will be initialized only if any valid URL was added; for invalid URL list can be null
// We just assert that builder didn't crash and message is present with content
assertEquals("hi", msg.getContent());
assertEquals("hello", msg.getContent());
}
}