3 Commits

Author SHA1 Message Date
7daf1915a5 Fix yet another pointer
All checks were successful
Build / build (push) Successful in 41s
2025-05-09 10:55:16 +02:00
029cf6ce01 Merge pull request 'Add support for pointer arguments' (#1) from add-support-for-ptr-args into master
All checks were successful
Build / build (push) Successful in 36s
Reviewed-on: #1
2025-05-09 10:23:46 +02:00
278d7ed497 Add support for pointer arguments
All checks were successful
Build / build (push) Successful in 1m13s
2025-05-09 10:18:08 +02:00
2 changed files with 33 additions and 4 deletions

View File

@@ -44,13 +44,17 @@ func (q *Query) bindInto(into *int, args ...any) *Query {
} }
for i, arg := range args { for i, arg := range args {
*into++ *into++
if arg == nil {
q.stmt.BindNull(*into)
continue
}
v := reflect.ValueOf(arg) v := reflect.ValueOf(arg)
if v.Kind() == reflect.Ptr { if v.Kind() == reflect.Ptr {
if v.IsNil() { if v.IsNil() {
q.stmt.BindNull(*into) q.stmt.BindNull(*into)
continue continue
} }
arg = v.Elem().Interface() // Dereference the pointer arg = v.Elem().Interface()
} }
if asString, ok := arg.(string); ok { if asString, ok := arg.(string); ok {
q.stmt.BindText(*into, asString) q.stmt.BindText(*into, asString)

View File

@@ -94,9 +94,14 @@ func TestUpdateQuery(t *testing.T) {
} }
func TestUpdateQueryWithWrongArguments(t *testing.T) { func TestUpdateQueryWithWrongArguments(t *testing.T) {
type S struct {
Field string
}
db := openTestDb(t) db := openTestDb(t)
value := "ipsum" abc := S{
err := db.Query("insert into mytable(key, value) values ('lorem', ?)").Bind(&value).Exec() Field: "ipsum",
}
err := db.Query("insert into mytable(key, value) values ('lorem', ?)").Bind(abc).Exec()
require.Error(t, err) require.Error(t, err)
} }
@@ -117,6 +122,26 @@ func TestUpdateQueryWithPointerValue(t *testing.T) {
require.Equal(t, "ipsum", value) require.Equal(t, "ipsum", value)
} }
func TestUpdateQueryWithSetPointerValue(t *testing.T) {
type S struct {
value *string
}
db := openTestDb(t)
func() {
tx := db.MustBegin()
defer tx.MustRollback()
tx.Query("insert into mytable(key, value) values ('lorem', 'bar')").MustExec()
s := S{nil}
key := "lorem"
tx.Query("update mytable set value = ? where key = ?").Bind(s.value, key).MustExec()
tx.MustCommit()
}()
var value *string
db.Query("select value from mytable where key = 'lorem'").MustScanSingle(&value)
require.Equal(t, (*string)(nil), value)
}
func TestUpdateQueryWithNullValue(t *testing.T) { func TestUpdateQueryWithNullValue(t *testing.T) {
db := openTestDb(t) db := openTestDb(t)
func() { func() {
@@ -128,7 +153,7 @@ func TestUpdateQueryWithNullValue(t *testing.T) {
tx.MustCommit() tx.MustCommit()
}() }()
var value string var value *string
db.Query("select value from mytable where key = 'lorem'").MustScanSingle(&value) db.Query("select value from mytable where key = 'lorem'").MustScanSingle(&value)
require.Nil(t, value) require.Nil(t, value)
} }