seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

Cool-Retro-Term in a Docker Container #474

Closed
aric49 wants to merge 6 commits from aric49/feature/Docker into master
pull from: aric49/feature/Docker
merge into: seeseemelk:master
Conversation 3 Commits 6 Files Changed 2 +1 -4
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a445ab4b86 - Show all commits

5
Dockerfile
View File

@@ -1,4 +1,4 @@
FROM ubuntu:18.04 as builder FROM ubuntu:18.04
#TODO: Clean up after installation and building #TODO: Clean up after installation and building
RUN apt-get update && apt-get install -y build-essential qml-module-qtgraphicaleffects qml-module-qt-labs-folderlistmodel qml-module-qt-labs-settings qml-module-qtquick-controls qml-module-qtquick-dialogs qmlscene qt5-default qt5-qmake qtdeclarative5-dev qtdeclarative5-localstorage-plugin qtdeclarative5-qtquick2-plugin qtdeclarative5-window-plugin RUN apt-get update && apt-get install -y build-essential qml-module-qtgraphicaleffects qml-module-qt-labs-folderlistmodel qml-module-qt-labs-settings qml-module-qtquick-controls qml-module-qtquick-dialogs qmlscene qt5-default qt5-qmake qtdeclarative5-dev qtdeclarative5-localstorage-plugin qtdeclarative5-qtquick2-plugin qtdeclarative5-window-plugin
apiraino commented 2019-01-11 14:33:01 +01:00 (Migrated from github.com)
Review
Copy Link
RUN apt-get update && apt-get install -y  build-essential qml-module-qtgraphicaleffects qml-module-qt-labs-folderlistmodel qml-module-qt-labs-settings qml-module-qtquick-controls qml-module-qtquick-dialogs qmlscene qt5-default qt5-qmake qtdeclarative5-dev qtdeclarative5-localstorage-plugin qtdeclarative5-qtquick2-plugin qtdeclarative5-window-plugin
RUN apt-get -yyq autoremove && \
        apt-get clean -yyq && \
        rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
```suggestion RUN apt-get update && apt-get install -y build-essential qml-module-qtgraphicaleffects qml-module-qt-labs-folderlistmodel qml-module-qt-labs-settings qml-module-qtquick-controls qml-module-qtquick-dialogs qmlscene qt5-default qt5-qmake qtdeclarative5-dev qtdeclarative5-localstorage-plugin qtdeclarative5-qtquick2-plugin qtdeclarative5-window-plugin RUN apt-get -yyq autoremove && \ apt-get clean -yyq && \ rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* ```
aric49 commented 2019-01-12 01:57:44 +01:00 (Migrated from github.com)
Review
Copy Link

Thanks for the input @apiraino! I almost forgot about that change. Good catch!

Thanks for the input @apiraino! I almost forgot about that change. Good catch!
@@ -12,6 +12,3 @@ WORKDIR /app
RUN chmod +x /app/cool-retro-term RUN chmod +x /app/cool-retro-term
USER user USER user
ENTRYPOINT ["./cool-retro-term"] ENTRYPOINT ["./cool-retro-term"]
#running: docker run -it --privileged --rm -e DISPLAY=$DISPLAY -e XDG_RUNTIME_DIR=/run/user/1000 -e XAUTHORITY=$XAUTHORITY -v /run/user/1000:/run/user/1000 -v /tmp/.X11-unix:/tmp/.X11-unix -v /dev/dri:/dev/dri retro-term:5