seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues449 Pull Requests12 Actions Packages Projects Releases8 Wiki Activity

Bug: Cool-retro-term does not heed preserved window size in app settings, falls back to 1024x768 default #824

New Issue
Open
opened 2023-11-18 04:47:06 +01:00 by kcbrown · 2 comments
kcbrown commented 2023-11-18 04:47:06 +01:00 (Migrated from github.com)

When you close cool-retro-term, it stores the current window positioning and dimensions in the app settings structure (a sqlite3 database). The intention behind this is to restore those settings at startup so that when you re-open the application, it picks up where it left off as regards size and positioning.

Under Ubuntu 23.04 (and, really, all of the recent versions of Ubuntu I've used this on), this doesn't work.

The reason is that the ordering of object initialization isn't guaranteed by the underlying Qt framework, and the end result is that, at least on the platforms I've used it, the main window initializes before the settings are loaded from the database. This results in the defaults being used.

Here's the fix:

diff --git a/app/qml/main.qml b/app/qml/main.qml
index 8ae0774..9848dbb 100644
--- a/app/qml/main.qml
+++ b/app/qml/main.qml
@@ -26,14 +26,32 @@ import "menus"
 ApplicationWindow {
     id: terminalWindow
 
-    width: 1024
-    height: 768
+    width: (appSettings.width > 0 ? appSettings.width : 1024)
+    height: (appSettings.height > 0 ? appSettings.height : 768)
+
+    property bool initialized: false
 
     // Save window properties automatically
-    onXChanged: appSettings.x = x
-    onYChanged: appSettings.y = y
-    onWidthChanged: appSettings.width = width
-    onHeightChanged: appSettings.height = height
+    onXChanged: {
+        if (initialized) {
+            appSettings.x = x
+        }
+    }
+    onYChanged: {
+        if (initialized) {
+            appSettings.y = y
+        }
+    }
+    onWidthChanged: {
+        if (initialized) {
+            appSettings.width = width
+        }
+    }
+    onHeightChanged: {
+        if (initialized) {
+            appSettings.height = height
+        }
+    }
 
     // Load saved window geometry and show the window
     Component.onCompleted: {
@@ -41,6 +59,7 @@ ApplicationWindow {
         y = appSettings.y
         width = appSettings.width
         height = appSettings.height
+        console.warn("onCompleted called.  Width = ", width, ", height = ", height)
 
         visible = true
     }
@@ -55,6 +74,19 @@ ApplicationWindow {
 
     menuBar: qtquickMenuLoader.item
 
+    Connections {
+        target: appSettings
+
+        function onInitializedSettings() {
+            x = appSettings.x
+            y = appSettings.y
+            width = appSettings.width
+            height = appSettings.height
+            initialized = true
+            console.warn("onInitializedSettings called.  Width = ", width, ", height = ", height)
+        }
+    }
+
     Loader {
         id: qtquickMenuLoader
         active: !appSettings.isMacOS && appSettings.showMenubar
When you close cool-retro-term, it stores the current window positioning and dimensions in the app settings structure (a sqlite3 database). The intention behind this is to restore those settings at startup so that when you re-open the application, it picks up where it left off as regards size and positioning. Under Ubuntu 23.04 (and, really, all of the recent versions of Ubuntu I've used this on), this doesn't work. The reason is that the ordering of object initialization isn't guaranteed by the underlying Qt framework, and the end result is that, at least on the platforms I've used it, the main window initializes before the settings are loaded from the database. This results in the defaults being used. Here's the fix: ``` diff --git a/app/qml/main.qml b/app/qml/main.qml index 8ae0774..9848dbb 100644 --- a/app/qml/main.qml +++ b/app/qml/main.qml @@ -26,14 +26,32 @@ import "menus" ApplicationWindow { id: terminalWindow - width: 1024 - height: 768 + width: (appSettings.width > 0 ? appSettings.width : 1024) + height: (appSettings.height > 0 ? appSettings.height : 768) + + property bool initialized: false // Save window properties automatically - onXChanged: appSettings.x = x - onYChanged: appSettings.y = y - onWidthChanged: appSettings.width = width - onHeightChanged: appSettings.height = height + onXChanged: { + if (initialized) { + appSettings.x = x + } + } + onYChanged: { + if (initialized) { + appSettings.y = y + } + } + onWidthChanged: { + if (initialized) { + appSettings.width = width + } + } + onHeightChanged: { + if (initialized) { + appSettings.height = height + } + } // Load saved window geometry and show the window Component.onCompleted: { @@ -41,6 +59,7 @@ ApplicationWindow { y = appSettings.y width = appSettings.width height = appSettings.height + console.warn("onCompleted called. Width = ", width, ", height = ", height) visible = true } @@ -55,6 +74,19 @@ ApplicationWindow { menuBar: qtquickMenuLoader.item + Connections { + target: appSettings + + function onInitializedSettings() { + x = appSettings.x + y = appSettings.y + width = appSettings.width + height = appSettings.height + initialized = true + console.warn("onInitializedSettings called. Width = ", width, ", height = ", height) + } + } + Loader { id: qtquickMenuLoader active: !appSettings.isMacOS && appSettings.showMenubar ```
ssrublev commented 2024-01-06 08:36:08 +01:00 (Migrated from github.com)

Same here with Fedora 39

Same here with Fedora 39
Inu-Yasha commented 2024-03-14 14:05:00 +01:00 (Migrated from github.com)

I'm using Fedora 39 as well and came here for a similar reason. I think,
a) the settings should have an option on whether to preserve the last time size
b) there should be also options to define custom size or launching as maximized
c) there should also be command line options for using custom geometry and to launch maximized - there's only one for launching fullscreen according to the man-page. If I'm wrong, the man page is wrong and doesn't list all the options.

I'm using Fedora 39 as well and came here for a similar reason. I think, a) the settings should have an option on whether to preserve the last time size b) there should be also options to define custom size or launching as maximized c) there should also be command line options for using custom geometry and to launch maximized - there's only one for launching fullscreen according to the man-page. If I'm wrong, the man page is wrong and doesn't list all the options.
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#824
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?