seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

Hide visible scrolling in background staticNoise #768

Merged
aaronkollasch merged 1 commits from aaronkollasch/random-static-noise into master 2024-10-11 10:57:00 +02:00
Conversation 0 Commits 1 Files Changed 1 +16 -1
aaronkollasch commented 2022-11-17 06:09:02 +01:00 (Migrated from github.com)
Copy Link

The current background staticNoise is generated by scrolling a noise texture. However, I find that this scrolling is visible, most clearly with large window sizes on high-resolution displays. To me, this distracts from the illusion of static noise.

This PR pseudo-randomizes the vertical position of the staticNoise texel and adds that to the pre-existing scrolling of noise texture (both horizontal and vertical; faster in vertical direction). I've found that produces the best balance of hiding visible scrolling while preserving the smoothness of the previous animation. (The pseudo-random function applied to the time variable seems to produce jerky outputs if used on its own, but they aren't visible when scrolling is also applied.)

The static noise still isn't perfect on large windows with this PR applied (mostly due to the fixed 512x512 texture), but the obvious scrolling artifact is removed.

The current background staticNoise is generated by scrolling a noise texture. However, I find that this scrolling is visible, most clearly with large window sizes on high-resolution displays. To me, this distracts from the illusion of static noise. This PR pseudo-randomizes the vertical position of the staticNoise texel and adds that to the pre-existing scrolling of noise texture (both horizontal and vertical; faster in vertical direction). I've found that produces the best balance of hiding visible scrolling while preserving the smoothness of the previous animation. (The pseudo-random function applied to the time variable seems to produce jerky outputs if used on its own, but they aren't visible when scrolling is also applied.) The static noise still isn't perfect on large windows with this PR applied (mostly due to the fixed 512x512 texture), but the obvious scrolling artifact is removed.
seeseemelk force-pushed aaronkollasch/random-static-noise from a683c5ad85 to b69610d7f3 2024-10-11 10:56:19 +02:00 Compare
seeseemelk merged commit e3c2e024bb into master 2024-10-11 10:57:00 +02:00
seeseemelk deleted branch aaronkollasch/random-static-noise 2024-10-11 10:57:00 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#768
No description provided.
Delete Branch "aaronkollasch/random-static-noise"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?