Black background escape code handled incorrectly #556

New Issue

2019-11-03T18:35:04+01:00

ashpool37 commented

2019-11-03 18:35:04 +01:00

(Migrated from github.com)

As of now it seems that when CRT draws a character on black background (i.e. after receiving an escape code like \033[40m or \033[30m\033[7m (black foreground, inverted)) it uses the theme's "Background" color instead of some fixed black color. This leads to confusion in programs which use black as a separate background color, as distinguished from "no background", which has its own escape code (\033[49m or \033[39m\033[7m).

One example of such a program is the game NetHack.

In this screenshot there are two terminal emulators rendering the ( symbol on black background.
Top: Terminator, black background distinguished from no background
Bottom: Cool Retro Term, black background blends with the default background color, which leads to the symbol rendered invisible.

This is not to mention that the theme background color might hypothetically be not black at all.

As of now it seems that when CRT draws a character on black background (i.e. after receiving an escape code like `\033[40m` or `\033[30m\033[7m` (black foreground, inverted)) it uses the theme's "Background" color instead of some fixed black color. This leads to confusion in programs which use black as a separate background color, as distinguished from "no background", which has its own escape code (`\033[49m` or `\033[39m\033[7m`). One example of such a program is the game NetHack. ![image](https://user-images.githubusercontent.com/14354287/68089336-ddaace00-fe78-11e9-95ce-e5db197feb3e.png) In this screenshot there are two terminal emulators rendering the `(` symbol on black background. Top: Terminator, black background distinguished from no background Bottom: Cool Retro Term, black background blends with the default background color, which leads to the symbol rendered invisible. This is not to mention that the theme background color might hypothetically be not black at all.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#556