seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

Add blinking cursor support #540

Merged
kklemon merged 3 commits from support-blinking-cursor into master 2020-05-09 16:37:50 +02:00
Conversation 7 Commits 3 Files Changed 4 +26 -2
kklemon commented 2019-07-08 15:38:20 +02:00 (Migrated from github.com)
Copy Link

Adds support for blinking cursor.

The qmltermwidget submodule is updated to expose a corresponding property (see https://github.com/Swordfish90/qmltermwidget/pull/25).

The blinking cursor option is enabled by default and can be tweaked in the terminal settings tab.

Adds support for blinking cursor. The `qmltermwidget` submodule is updated to expose a corresponding property (see https://github.com/Swordfish90/qmltermwidget/pull/25). The blinking cursor option is enabled by default and can be tweaked in the _terminal_ settings tab.
👍 3 ❤️ 1
Swordfish90 commented 2019-07-20 16:29:18 +02:00 (Migrated from github.com)
Copy Link

Hi @kklemon . This looks very good, thank you. The problem I see with blinking cursor is that it might be a bit heavy on resources (since it's a whole terminal repaint at every second), could you please set it by default to false and update the default profiles to have it disabled (this should avoid breaking backward compatibility)?

Hi @kklemon . This looks very good, thank you. The problem I see with blinking cursor is that it might be a bit heavy on resources (since it's a whole terminal repaint at every second), could you please set it by default to false and update the default profiles to have it disabled (this should avoid breaking backward compatibility)?
kklemon commented 2019-07-20 16:47:44 +02:00 (Migrated from github.com)
Copy Link

That's a valid point but the cursor does only blink if the window is focused and in this case, the user is probably typing anyway which also casts redraws. Also, the 500 ms default blink interval is much longer than the ones of most other effects.

But disabling it by default for backward compatibility is a good point.

That's a valid point but the cursor does only blink if the window is focused and in this case, the user is probably typing anyway which also casts redraws. Also, the 500 ms default blink interval is much longer than the ones of most other effects. But disabling it by default for backward compatibility is a good point.
👍 1
Swordfish90 commented 2020-05-09 16:38:15 +02:00 (Migrated from github.com)
Copy Link

Thank you very much and sorry for the very long delay with this pull request.

Thank you very much and sorry for the very long delay with this pull request.
iamchriswick commented 2021-03-17 03:10:56 +01:00 (Migrated from github.com)
Copy Link

Is there support for blinking cursor now? And if so, how do I enable it? 😄

EDIT 1: I can see that there was added support for it on May 29 2020, but that there is no release for at, so will you release v1.1.2?

EDIT 2: Just tried to build , but get the following error:

Fontconfig error: "/etc/fonts/local.conf", line 1: no element found
QQmlApplicationEngine failed to load component
qrc:/main.qml:137:5: Type TerminalContainer unavailable
qrc:/TerminalContainer.qml:23:5: Type PreprocessedTerminal unavailable
qrc:/PreprocessedTerminal.qml:97:9: Cannot assign to non-existent property "blinkingCursor"
Cannot load QML interface
Is there support for blinking cursor now? And if so, how do I enable it? :smile: **EDIT 1:** I can see that there was added support for it on May 29 2020, but that there is no release for at, so will you release v1.1.2? **EDIT 2:** Just tried to build , but get the following error: ``` Fontconfig error: "/etc/fonts/local.conf", line 1: no element found QQmlApplicationEngine failed to load component qrc:/main.qml:137:5: Type TerminalContainer unavailable qrc:/TerminalContainer.qml:23:5: Type PreprocessedTerminal unavailable qrc:/PreprocessedTerminal.qml:97:9: Cannot assign to non-existent property "blinkingCursor" Cannot load QML interface ```
kklemon commented 2021-03-17 11:03:35 +01:00 (Migrated from github.com)
Copy Link

I haven't been involved with the project for quite some time, but indeed the feature is merged into master but with no release yet.

If you want to build it manually, you have to build and install https://github.com/Swordfish90/qmltermwidget from master as well, as the functionality is essentially implemented there.

I haven't been involved with the project for quite some time, but indeed the feature is merged into master but with no release yet. If you want to build it manually, you have to build and install https://github.com/Swordfish90/qmltermwidget from master as well, as the functionality is essentially implemented there.
andmarti1424 commented 2021-04-20 00:44:41 +02:00 (Migrated from github.com)
Copy Link

I get the same. I have built that qmltermwidget and generated the libqmltermwidget.so. but where I need to place it so it can work? Thanks.

I get the same. I have built that qmltermwidget and generated the libqmltermwidget.so. but where I need to place it so it can work? Thanks.
andmarti1424 commented 2021-04-20 01:06:04 +02:00 (Migrated from github.com)
Copy Link

I answer my self. It goes in /usr/lib/qt/qml/QMLTermWidget/libqmltermwidget.so

I answer my self. It goes in /usr/lib/qt/qml/QMLTermWidget/libqmltermwidget.so
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#540
No description provided.
Delete Branch "support-blinking-cursor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?