seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

CRT doesn't support DECSCUSR xterm sequence #481

New Issue
Open
opened 2018-11-22 12:49:33 +01:00 by LunarLambda · 5 comments
LunarLambda commented 2018-11-22 12:49:33 +01:00 (Migrated from github.com)
Copy Link

From https://invisible-island.net/xterm/ctlseqs/ctlseqs.html:
image

CRT doesn't properly parse this sequence, causing characters on screen to be overwritten with 'q' when t_SI, t_EI, and t_SR are set in Vim.

CRT should either: Accept it but ignore it, or provide its own terminfo entry based on xterm with those capabilities removed.

Also, perhaps it could report TERM as xterm-256color, since it correctly supports 256/truecolor sequences.

From https://invisible-island.net/xterm/ctlseqs/ctlseqs.html: ![image](https://user-images.githubusercontent.com/38919842/48967706-1d203780-efe5-11e8-9837-70d7ac76850d.png) CRT doesn't properly parse this sequence, causing characters on screen to be overwritten with 'q' when t_SI, t_EI, and t_SR are set in Vim. CRT should either: Accept it but ignore it, or provide its own terminfo entry based on xterm with those capabilities removed. Also, perhaps it could report TERM as xterm-256color, since it correctly supports 256/truecolor sequences.
WhiskeyTuesday commented 2018-11-23 23:19:03 +01:00 (Migrated from github.com)
Copy Link

I haven't had any issues with stock vim, but I run inside of tmux with $TERM set to xterm-256color in the .tmux.conf

I haven't had any issues with stock vim, but I run inside of tmux with $TERM set to xterm-256color in the .tmux.conf
yurikhan commented 2018-11-24 11:11:09 +01:00 (Migrated from github.com)
Copy Link

@WhiskeyTuesday Having an xterm-based $TERM inside tmux is wrong and you should not suggest that. See this comment for details.

@WhiskeyTuesday Having an `xterm`-based $TERM inside tmux is wrong and you should not suggest that. See [this comment][1] for details. [1]: https://github.com/neovim/neovim/issues/6845#issuecomment-306258721
WhiskeyTuesday commented 2018-11-24 11:13:16 +01:00 (Migrated from github.com)
Copy Link

Firstly, I didn't actually suggest anything. Secondly, I meant to say I have it set to screen-256-color.

Firstly, I didn't actually suggest anything. Secondly, I meant to say I have it set to screen-256-color.
LunarLambda commented 2018-11-24 11:57:51 +01:00 (Migrated from github.com)
Copy Link

Update: 'stock' vim seems to be working fine indeed (8.1, with crt 1.0.1, with or without tmux), but nvim is still completely broken.

Update: 'stock' vim seems to be working fine indeed (8.1, with crt 1.0.1, with or without tmux), but nvim is still completely broken.
LunarLambda commented 2018-11-24 12:38:52 +01:00 (Migrated from github.com)
Copy Link

I've updated the issue to reflect the actual issue. As for Neovim support, I think that will have to be fixed by them, not CRT.

I've updated the issue to reflect the _actual_ issue. As for Neovim support, I think that will have to be fixed by them, not CRT.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#481
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?