seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

MacOS X 10.9.4 compatible version of cool-old-term #47

Closed
aacalfa wants to merge 4 commits from master into master
pull from: master
merge into: seeseemelk:master
Conversation 7 Commits 4 Files Changed 5 +209 -1
aacalfa commented 2014-07-31 19:32:46 +02:00 (Migrated from github.com)
Copy Link

Modifications:
1 - Modified kpty.cpp, by putting the implementations of utmp.h functions.
2 - Created a dummy banana method to get through linking, in TerminalDisplay.cpp.

Modifications: 1 - Modified kpty.cpp, by putting the implementations of utmp.h functions. 2 - Created a dummy banana method to get through linking, in TerminalDisplay.cpp.
Swordfish90 commented 2014-07-31 22:14:51 +02:00 (Migrated from github.com)
Copy Link

Very well, but please could you cleanup the code. Instead of copy and pasting the functions would be better to add the file in the project and import it here. Another problem is that those functions are compiled always, even under linux where they are not needed. You should use a flag to tell the compiler that those funcitons are only for OSX (an #ifdef basically). If you have any problem I'm here fixing other issues.

Very well, but please could you cleanup the code. Instead of copy and pasting the functions would be better to add the file in the project and import it here. Another problem is that those functions are compiled always, even under linux where they are not needed. You should use a flag to tell the compiler that those funcitons are only for OSX (an #ifdef basically). If you have any problem I'm here fixing other issues.
aacalfa commented 2014-07-31 23:59:23 +02:00 (Migrated from github.com)
Copy Link

Sorry about that. Do you have any preferences on naming the file and functions? I'll do that later and add the changes here.

Sorry about that. Do you have any preferences on naming the file and functions? I'll do that later and add the changes here.
Swordfish90 commented 2014-08-01 01:10:20 +02:00 (Migrated from github.com)
Copy Link

No problem. You can leave the names they have now, they are fine for me. And thank you again for your help.

No problem. You can leave the names they have now, they are fine for me. And thank you again for your help.
aacalfa commented 2014-08-01 03:37:59 +02:00 (Migrated from github.com)
Copy Link

Okay I guess I'm done. Please tell me if there's anything that should be corrected :)

Okay I guess I'm done. Please tell me if there's anything that should be corrected :)
Swordfish90 commented 2014-08-01 18:12:46 +02:00 (Migrated from github.com)
Copy Link

Thank you the patch is now online in the branch osx.

Thank you the patch is now online in the branch osx.
pavellishin commented 2014-08-05 18:53:51 +02:00 (Migrated from github.com)
Copy Link

I'm having some trouble building this on OS X - is this the proper ticket to address this in, or should I open a new one?

I'm having some trouble building this on OS X - is this the proper ticket to address this in, or should I open a new one?
e1senh0rn commented 2014-08-05 18:57:38 +02:00 (Migrated from github.com)
Copy Link

@pavellishin Are you trying master or osx branch?

@pavellishin Are you trying master or osx branch?

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#47
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?