seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues449 Pull Requests12 Actions Packages Projects Releases8 Wiki Activity

Horizontal bleeding on scanlines #344

New Issue
Open
opened 2017-05-01 00:49:32 +02:00 by ryanfelder · 1 comment
ryanfelder commented 2017-05-01 00:49:32 +02:00 (Migrated from github.com)

Heya Swordfish90, been a long time.

I use cool-retro-term daily on both my home desktop and my work desktop and it's gorgeous, but there's one thing that breaks immersion for me moderately. While the scanlines have good fade off on the vertical axis, the horizontal axis ends abruptly. I kindof get around this by turning texture quality down.

If there was a filter that performed a horizontal blur with a convolution matrix, I think it would improve the look of cool-retro-term.

In GIMP, I can achieve a result like what I'm hoping for with a Filter->Generic->Convolution Matrix of:

1, 0, 1
3,15,3
1, 0, 1

Divisor 24

Example of GIMP Filters : http://imgur.com/a/SwdUO

It's not just a straight horizontal blur, it halos the pixels diagonal a bit as well. I do have bloom turned on, but the existing vertical blur with no horizontal blur on the font means if I turn bloom up enough to satisfy my desire for horizontal blur, the image is massively over-bloomed.

I'm not sure how this translates to QML shaders, but a quick googling shows uniform mat4 qt_Matrix seems similar. Maybe this is just a modification of your existing matrix multiplication?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Heya Swordfish90, been a long time. I use cool-retro-term daily on both my home desktop and my work desktop and it's gorgeous, but there's one thing that breaks immersion for me moderately. While the scanlines have good fade off on the vertical axis, the horizontal axis ends abruptly. I kindof get around this by turning texture quality down. If there was a filter that performed a horizontal blur with a convolution matrix, I think it would improve the look of cool-retro-term. In GIMP, I can achieve a result like what I'm hoping for with a Filter->Generic->Convolution Matrix of: 1, 0, 1 3,15,3 1, 0, 1 Divisor 24 Example of GIMP Filters : http://imgur.com/a/SwdUO It's not just a straight horizontal blur, it halos the pixels diagonal a bit as well. I do have bloom turned on, but the existing vertical blur with no horizontal blur on the font means if I turn bloom up enough to satisfy my desire for horizontal blur, the image is massively over-bloomed. I'm not sure how this translates to QML shaders, but a quick googling shows uniform mat4 qt_Matrix seems similar. Maybe this is just a modification of your existing matrix multiplication? <bountysource-plugin> --- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/44703080-horizontal-bleeding-on-scanlines?utm_campaign=plugin&utm_content=tracker%2F479407&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F479407&utm_medium=issues&utm_source=github). </bountysource-plugin>
ryanfelder commented 2017-05-01 01:18:13 +02:00 (Migrated from github.com)

After turning off many of my shaders (bloom, screen curvature) and examining screenshots very closely, it appears you are already doing this, but maybe in a slightly more subtle way than I was expecting.

After turning off many of my shaders (bloom, screen curvature) and examining screenshots very closely, it appears you are already doing this, but maybe in a slightly more subtle way than I was expecting.
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#344
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?