seeseemelk/cool-retro-term
1
0
Fork 0
Code Issues 449 Pull Requests 12 Actions Packages Projects Releases 8 Wiki Activity

Chroma color #128

New Issue
Open
opened 2014-09-24 05:42:42 +02:00 by exileshadow · 3 comments
exileshadow commented 2014-09-24 05:42:42 +02:00 (Migrated from github.com)
Copy Link

Just wondering what happened to the chroma color option? Are there any plans on allowing users to edit their color pallet?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/4703146-chroma-color?utm_campaign=plugin&utm_content=tracker%2F479407&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F479407&utm_medium=issues&utm_source=github).
Just wondering what happened to the chroma color option? Are there any plans on allowing users to edit their color pallet? ## <bountysource-plugin> --- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/4703146-chroma-color?utm_campaign=plugin&utm_content=tracker%2F479407&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F479407&utm_medium=issues&utm_source=github). </bountysource-plugin>
Swordfish90 commented 2014-09-24 11:25:25 +02:00 (Migrated from github.com)
Copy Link

Hi, what happened to the chroma color slider? Are you experiencing any issue? I just retested it and it works fine for me. The support for color profiles might be a bit tricky. The extremely simple solution of the chroma color works well in the majority of cases, but relies on some assumptions (foreground has to be white and background has to be black as example), then everything is colorized in post processing. All this to say that I'm still undecided if that's worth the effort, I will make some tests to see if we can find some smart ways to do that, but that's not going to happen soon.

Hi, what happened to the chroma color slider? Are you experiencing any issue? I just retested it and it works fine for me. The support for color profiles might be a bit tricky. The extremely simple solution of the chroma color works well in the majority of cases, but relies on some assumptions (foreground has to be white and background has to be black as example), then everything is colorized in post processing. All this to say that I'm still undecided if that's worth the effort, I will make some tests to see if we can find some smart ways to do that, but that's not going to happen soon.
exileshadow commented 2014-09-24 21:52:32 +02:00 (Migrated from github.com)
Copy Link

Gotcha, mind if i take a crack at it? I have a bit of experience with
shaders and i think i may know how to get this working. Essentially each
color option would need to have its own individualized pass (color1,
color2, etc). Ill keep you updated with anything i can find.
On Sep 24, 2014 5:25 AM, "Filippo Scognamiglio" notifications@github.com
wrote:

Hi, what happened to the chroma color slider? Are you experiencing any
issue? I just retested it and it works fine for me. The support for color
profiles might be a bit tricky. The extremely simple solution of the chroma
color works well in the majority of cases, but relies on some assumptions
(foreground has to be white and background has to be black as example),
then everything is colorized in post processing. All this to say that I'm
still undecided if that's worth the effort, I will make some tests to see
if we can find some smart ways to do that, but that's not going to happen
soon.

—
Reply to this email directly or view it on GitHub
https://github.com/Swordfish90/cool-retro-term/issues/128#issuecomment-56645481
.

Gotcha, mind if i take a crack at it? I have a bit of experience with shaders and i think i may know how to get this working. Essentially each color option would need to have its own individualized pass (color1, color2, etc). Ill keep you updated with anything i can find. On Sep 24, 2014 5:25 AM, "Filippo Scognamiglio" notifications@github.com wrote: > Hi, what happened to the chroma color slider? Are you experiencing any > issue? I just retested it and it works fine for me. The support for color > profiles might be a bit tricky. The extremely simple solution of the chroma > color works well in the majority of cases, but relies on some assumptions > (foreground has to be white and background has to be black as example), > then everything is colorized in post processing. All this to say that I'm > still undecided if that's worth the effort, I will make some tests to see > if we can find some smart ways to do that, but that's not going to happen > soon. > > — > Reply to this email directly or view it on GitHub > https://github.com/Swordfish90/cool-retro-term/issues/128#issuecomment-56645481 > .
Swordfish90 commented 2014-09-25 00:50:15 +02:00 (Migrated from github.com)
Copy Link

External help is really really welcomed! :) ... I think a pass for each color might be a little overkill. We have control over the profiles so we acheive that in preprocessing instead of postprocessing. To give you an example in the terminal app for ubuntu touch we are using a different approach. We render the texture with the selected profile (Dark pastel, Linux, whateer), then we colorize the texture with the screen color selected (amber, green ...). The advantage profiles are supported by default, the disadvantage is that you can't have something like "White over Blue" without modifying both the profile and the screen color. I think that if we allow profile customization here that's probably the way to go, but I'm eager to know if you have a better idea.

External help is really really welcomed! :) ... I think a pass for each color might be a little overkill. We have control over the profiles so we acheive that in preprocessing instead of postprocessing. To give you an example in the terminal app for ubuntu touch we are using a different approach. We render the texture with the selected profile (Dark pastel, Linux, whateer), then we colorize the texture with the screen color selected (amber, green ...). The advantage profiles are supported by default, the disadvantage is that you can't have something like "White over Blue" without modifying both the profile and the screen color. I think that if we allow profile customization here that's probably the way to go, but I'm eager to know if you have a better idea.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bounty
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
seeseemelk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: seeseemelk/cool-retro-term#128
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?