From 5ef1ea906da69e11edc33052ab4b4bf4377bfbf7 Mon Sep 17 00:00:00 2001
From: Amith Koujalgi <koujalgi.amith@gmail.com>
Date: Sat, 20 Sep 2025 17:48:21 +0530
Subject: [PATCH] Remove modelKeepAliveTime property and related code

Eliminated the modelKeepAliveTime field from OllamaAPI and OllamaChatRequest, along with its usage in integration tests and configuration. This streamlines configuration and request handling by removing an unused or deprecated parameter.
---
 src/main/java/io/github/ollama4j/OllamaAPI.java               | 4 ----
 .../io/github/ollama4j/models/chat/OllamaChatRequest.java     | 4 ----
 .../ollama4j/integrationtests/OllamaAPIIntegrationTest.java   | 3 ---
 .../unittests/jackson/TestChatRequestSerialization.java       | 4 ++--
 src/test/resources/test-config.properties                     | 3 +--
 5 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/src/main/java/io/github/ollama4j/OllamaAPI.java b/src/main/java/io/github/ollama4j/OllamaAPI.java
index 985eaf0..beed9b4 100644
--- a/src/main/java/io/github/ollama4j/OllamaAPI.java
+++ b/src/main/java/io/github/ollama4j/OllamaAPI.java
@@ -92,10 +92,6 @@ public class OllamaAPI {
     @SuppressWarnings({"FieldMayBeFinal", "FieldCanBeLocal"})
     private int numberOfRetriesForModelPull = 0;
 
-    @Setter
-    @SuppressWarnings({"FieldMayBeFinal", "FieldCanBeLocal"})
-    private int modelKeepAliveTime = 0;
-
     /**
      * Instantiates the Ollama API with default Ollama host: <a
      * href="http://localhost:11434">http://localhost:11434</a>
diff --git a/src/main/java/io/github/ollama4j/models/chat/OllamaChatRequest.java b/src/main/java/io/github/ollama4j/models/chat/OllamaChatRequest.java
index a208ecb..38ec0b3 100644
--- a/src/main/java/io/github/ollama4j/models/chat/OllamaChatRequest.java
+++ b/src/main/java/io/github/ollama4j/models/chat/OllamaChatRequest.java
@@ -8,7 +8,6 @@
 */
 package io.github.ollama4j.models.chat;
 
-import com.fasterxml.jackson.annotation.JsonProperty;
 import io.github.ollama4j.models.request.OllamaCommonRequest;
 import io.github.ollama4j.tools.Tools;
 import io.github.ollama4j.utils.OllamaRequestBody;
@@ -33,9 +32,6 @@ public class OllamaChatRequest extends OllamaCommonRequest implements OllamaRequ
 
     private boolean think;
 
-    @JsonProperty("keep_alive")
-    private int modelKeepAliveTime;
-
     /**
      * Controls whether tools are automatically executed.
      * <p>
diff --git a/src/test/java/io/github/ollama4j/integrationtests/OllamaAPIIntegrationTest.java b/src/test/java/io/github/ollama4j/integrationtests/OllamaAPIIntegrationTest.java
index 8eaf3fb..e0d66b1 100644
--- a/src/test/java/io/github/ollama4j/integrationtests/OllamaAPIIntegrationTest.java
+++ b/src/test/java/io/github/ollama4j/integrationtests/OllamaAPIIntegrationTest.java
@@ -71,7 +71,6 @@ class OllamaAPIIntegrationTest {
         // ... (no javadoc needed for private setup logic)
         int requestTimeoutSeconds = 60;
         int numberOfRetriesForModelPull = 5;
-        int modelKeepAliveTime = 0;
 
         try {
             String useExternalOllamaHostEnv = System.getenv("USE_EXTERNAL_OLLAMA_HOST");
@@ -99,7 +98,6 @@ class OllamaAPIIntegrationTest {
                         Integer.parseInt(props.getProperty("REQUEST_TIMEOUT_SECONDS"));
                 numberOfRetriesForModelPull =
                         Integer.parseInt(props.getProperty("NUMBER_RETRIES_FOR_MODEL_PULL"));
-                modelKeepAliveTime = Integer.parseInt(props.getProperty("MODEL_KEEP_ALIVE_TIME"));
             } else {
                 useExternalOllamaHost = Boolean.parseBoolean(useExternalOllamaHostEnv);
                 ollamaHost = ollamaHostEnv;
@@ -136,7 +134,6 @@ class OllamaAPIIntegrationTest {
         }
         api.setRequestTimeoutSeconds(requestTimeoutSeconds);
         api.setNumberOfRetriesForModelPull(numberOfRetriesForModelPull);
-        api.setModelKeepAliveTime(modelKeepAliveTime);
     }
 
     /**
diff --git a/src/test/java/io/github/ollama4j/unittests/jackson/TestChatRequestSerialization.java b/src/test/java/io/github/ollama4j/unittests/jackson/TestChatRequestSerialization.java
index e533090..1b1ad9a 100644
--- a/src/test/java/io/github/ollama4j/unittests/jackson/TestChatRequestSerialization.java
+++ b/src/test/java/io/github/ollama4j/unittests/jackson/TestChatRequestSerialization.java
@@ -146,7 +146,7 @@ public class TestChatRequestSerialization extends AbstractSerializationTest<Olla
         OllamaChatRequest req = builder.withKeepAlive(expectedKeepAlive).build();
         String jsonRequest = serialize(req);
         assertEquals(
-                deserialize(jsonRequest, OllamaChatRequest.class).getKeepAlive(),
-                expectedKeepAlive);
+                expectedKeepAlive,
+                deserialize(jsonRequest, OllamaChatRequest.class).getKeepAlive());
     }
 }
diff --git a/src/test/resources/test-config.properties b/src/test/resources/test-config.properties
index 0b656cb..62f46dd 100644
--- a/src/test/resources/test-config.properties
+++ b/src/test/resources/test-config.properties
@@ -1,5 +1,4 @@
 USE_EXTERNAL_OLLAMA_HOST=true
 OLLAMA_HOST=http://192.168.29.229:11434/
 REQUEST_TIMEOUT_SECONDS=120
-NUMBER_RETRIES_FOR_MODEL_PULL=3
-MODEL_KEEP_ALIVE_TIME=0
\ No newline at end of file
+NUMBER_RETRIES_FOR_MODEL_PULL=3
\ No newline at end of file