From 2b0238b9e80b3c3d90e0fb34933a9cf45ed57b46 Mon Sep 17 00:00:00 2001 From: Amith Koujalgi Date: Tue, 11 Mar 2025 12:26:35 +0530 Subject: [PATCH] Ensure Docker availability in dev setup and integration tests Updated `README.md` to include Docker as a prerequisite for running integration tests using Testcontainers. Modified the `Makefile` to check for Docker installation during the dev environment setup. --- Makefile | 1 + README.md | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 953c764..34972dd 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,7 @@ dev: @echo "Setting up dev environment..." @command -v pre-commit >/dev/null 2>&1 || { echo "Error: pre-commit is not installed. Please install it first."; exit 1; } + @command -v docker >/dev/null 2>&1 || { echo "Error: docker is not installed. Please install it first."; exit 1; } pre-commit install pre-commit autoupdate pre-commit install --install-hooks diff --git a/README.md b/README.md index a832a0c..33ac281 100644 --- a/README.md +++ b/README.md @@ -227,6 +227,9 @@ make unit-tests #### Run integration tests +Make sure you have Docker running as this uses [testcontainers](https://testcontainers.com/) to run the integration +tests on Ollama Docker container. + ```shell make integration-tests ``` @@ -325,7 +328,7 @@ project.

-### Appreciate my work? +### Appreciate the work?

Buy Me A Coffee